[MIRROR] Hemophagus, The Hemophage Revamp, DLC Chapter V: This PR Sucks (Blood) #724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…) (#24903) * initial d * wew * we lost a define in the war * Apply suggestions from code review Co-authored-by: GoldenAlpharex <[email protected]> * wew --------- Co-authored-by: Snakebittenn <[email protected]> Co-authored-by: GoldenAlpharex <[email protected]>
AnywayFarus
added a commit
that referenced
this pull request
Nov 20, 2023
Iajret
pushed a commit
that referenced
this pull request
Feb 1, 2024
* Fixes runtime from examining mod PCs (#81200) ## About The Pull Request It's a classic  `EXAMINE_HINT(x)` resolves to `"<b>" + x + "</b>"` When placed in this line directly, you get: `["<b>" + HAS_TRAIT_FROM(...) ? "..." : "..." + "</b>"]` You see the issue, right? This resolves as you would expect: `("<b>" + HAS_TRAIT_FROM(...)) ? ("...") : ("..." + "</b>")` Which, of course, runtimes as it's adding a string to an integer (0). By pulling it out to its own var we can get around this: `["<b>" + frame_or_pc + "</b>"]` ## Changelog :cl: Melbert fix: Fixed examining modular PCs /:cl: * Fixes runtime from examining mod PCs --------- Co-authored-by: MrMelbert <[email protected]>
ReezeBL
pushed a commit
that referenced
this pull request
Feb 6, 2024
* Fixes runtime from examining mod PCs (#81200) ## About The Pull Request It's a classic  `EXAMINE_HINT(x)` resolves to `"<b>" + x + "</b>"` When placed in this line directly, you get: `["<b>" + HAS_TRAIT_FROM(...) ? "..." : "..." + "</b>"]` You see the issue, right? This resolves as you would expect: `("<b>" + HAS_TRAIT_FROM(...)) ? ("...") : ("..." + "</b>")` Which, of course, runtimes as it's adding a string to an integer (0). By pulling it out to its own var we can get around this: `["<b>" + frame_or_pc + "</b>"]` ## Changelog :cl: Melbert fix: Fixed examining modular PCs /:cl: * Fixes runtime from examining mod PCs --------- Co-authored-by: NovaBot <[email protected]> Co-authored-by: MrMelbert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR: Skyrat-SS13/Skyrat-tg#24903
About The Pull Request
Hi! Me and the coven were talking, and the low rate of healing that hemophages experience really cramps our vampiric style.
This PR does two things.
First of all, Hemophage brute/burn healing has been upped; 2 for brute, 2 for burn, 1.75 for toxin, and 1.50 for cellular. These numbers (besides the toxin and cellular) are meant to reflect non-upgraded NR, and meant to still be worse options than dedicated libital and aiuri.
Second of all, hemophages now benefit from actual liquid blood a bit more; it functions like tea in that it helps with non-bone wounds, at the same rate that tea already does. This is because, well, they're unable to drink it 99% of the time; and it's an important ghetto option. This has necessitated hemophages being able to get blood out of drain victim, so I did that too, w/ special help from vinylspiders and Paxilmaniac.
The proc for the message to pop up has increased so you can tell wtf is happening.
How This Contributes To The Skyrat Roleplay Experience
This should make hemophages a bit more worthy of the whole 'regenerating creature of the night' title schtick and, once again, make actual blood a bit more compelling.
Proof of Testing
Screenshots/Videos
It's in the desc.Changelog
🆑 Nerev4r
balance: Hemophages now have higher healing numbers, and liquid blood helps non-bone wounds like tea does.
/:cl: